chore: refactor tests #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Simplify tests while keeping all scenarios under test - Modify tests to have a consistent style - Move log lines tests to the logger tests instead of the upgrader tests [#185853346](https://www.pivotaltracker.com/story/show/185853346)
zucchinidev
reviewed
Oct 5, 2023
| State: "failed", | ||
| }, | ||
| } | ||
| } |
There was a problem hiding this comment.
praise: thank you very much. It is easier to understand the obtained data when something fails
zucchinidev
reviewed
Oct 5, 2023
| } | ||
|
|
||
| func fullInstance(name, guid string, upgradeAvailable bool, lastOperationType, lastOperationState string) ccapi.ServiceInstance { | ||
| func indexedInstance(index int, upgradeAvailable bool) ccapi.ServiceInstance { |
zucchinidev
reviewed
Oct 5, 2023
| fakeInstanceCreateFailed ccapi.ServiceInstance | ||
| fakeInstanceDestroyFailed ccapi.ServiceInstance | ||
| fakeServiceInstances []ccapi.ServiceInstance | ||
| fakeServiceInstancesNoUpgrade []ccapi.ServiceInstance |
There was a problem hiding this comment.
praise: great contribution
zucchinidev
reviewed
Oct 5, 2023
| fakeCFClient.GetServicePlansReturns([]ccapi.Plan{}, nil) | ||
|
|
||
| err := upgrader.Upgrade(fakeCFClient, fakeBrokerName, 1, false, true, fakeLog) | ||
| Expect(err).To(MatchError(fmt.Sprintf("no service plans available for broker: %s", fakeBrokerName))) |
zucchinidev
reviewed
Oct 5, 2023
| @@ -108,28 +106,6 @@ func (l *Logger) FinalTotals() { | |||
| logRowFormatTotals(l) | |||
| } | |||
|
|
|||
| //lint:ignore U1000 Ignore unused function temporarily for better code review | |||
| func logOldFormatTotals(l *Logger) { | |||
zucchinidev
approved these changes
Oct 5, 2023
zucchinidev
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#185853346
Checklist:
* [ ] Have you added Release Notes in the docs respositories?