Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve textual output #89

Merged
merged 4 commits into from
Sep 19, 2023

Conversation

fnaranjo-vmw
Copy link
Contributor

@fnaranjo-vmw fnaranjo-vmw commented Sep 13, 2023

I strongly recommend reviewing this PR commit by commit, instead of looking at "Files changed".

Checklist:

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/186036712

The labels on this github issue will be updated when the story is started.

@fnaranjo-vmw fnaranjo-vmw changed the title Feat improve textual output #185716266 feat: improve textual output Sep 13, 2023
@fnaranjo-vmw fnaranjo-vmw force-pushed the feat-improve-textual-output-#185716266 branch from 3c22e25 to a5aa964 Compare September 13, 2023 20:26
[#185716266](https://www.pivotaltracker.com/story/show/185716266)

This commit doesn't add any of the required improvements.
It focuses on modifying function signatures to accommodate
the required improvements more cleanly in subsequent commits.

This commit alone is able to build but fails to run the tests
because autogenerated fakes got out of sync. I'll regenerate
these fakes in the following commit to simplify revision.
internal/upgrader/upgrader.go Outdated Show resolved Hide resolved
internal/upgrader/upgrader_test.go Outdated Show resolved Hide resolved
internal/logger/logger_test.go Outdated Show resolved Hide resolved
@fnaranjo-vmw fnaranjo-vmw force-pushed the feat-improve-textual-output-#185716266 branch from a5aa964 to dac15e9 Compare September 14, 2023 17:41
@fnaranjo-vmw fnaranjo-vmw force-pushed the feat-improve-textual-output-#185716266 branch from dac15e9 to 362de66 Compare September 14, 2023 17:56
internal/logger/logger_test.go Outdated Show resolved Hide resolved
@fnaranjo-vmw fnaranjo-vmw merged commit 6e48c57 into main Sep 19, 2023
6 checks passed
@fnaranjo-vmw fnaranjo-vmw deleted the feat-improve-textual-output-#185716266 branch September 19, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants