-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update plugin to check for a minimum required version #121
Merged
Merged
Changes from 18 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
6168db1
fix: check deactivated plans in instances without pending upgrade
zucchinidev 1e7f3cc
feat: check up to date also performs check deactivated plans
zucchinidev 7d488ab
chore: check-up-to-date check that it is set even with nil value
zucchinidev 9a2bb6c
test: improve description
zucchinidev f34fd9c
test: improve description
zucchinidev 563dcae
feat: check version when using -check-up-to-date
zucchinidev 767f4a1
fix: remove unnecessary code
zucchinidev 8d2c8ec
chore: delete unnecessary code
zucchinidev f4a3da9
Merge remote-tracking branch 'origin/main' into check_instances_up_to…
zucchinidev a0aa252
feat: update upgrade-all plugin to check for a minimum required version
zucchinidev 9b3bed7
test: use the real flag name
zucchinidev 03fb9b9
chore: use method name with a correct name
zucchinidev b57680c
chore: follow name conventions
zucchinidev 65e2b11
chore: use check-up-to-date flag instead of fail-if-not-up-to-date
zucchinidev ecb38a3
chore: use check-up-to-date in upgrader configuration
zucchinidev bd81435
chore: centralise validation
zucchinidev 0cbf0a3
test: update description
zucchinidev ac98b26
feat: remove incorrect method to improve readability
zucchinidev da44dcc
fix: typo in variable
zucchinidev 5c83394
chore: follow style conventions
zucchinidev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
package upgrader | ||
|
||
import ( | ||
"errors" | ||
) | ||
|
||
type MultiError struct { | ||
Errors []error | ||
} | ||
|
||
// Append adds a non-nil error to the MultiError. | ||
// If the provided error is nil, it will be ignored, preventing | ||
// nil errors from being included in the error slice. | ||
// This method simplifies error aggregation by centralizing nil checks. | ||
func (m *MultiError) Append(err error) { | ||
if err != nil { | ||
m.Errors = append(m.Errors, err) | ||
} | ||
} | ||
|
||
// Error implements the error interface. It returns a concatenated | ||
// string of all the non-nil errors it contains. If there are no non-nil | ||
// errors, it returns an empty string. | ||
// This method allows MultiError to seamlessly integrate with typical error handling in Go. | ||
func (m *MultiError) Error() string { | ||
return errors.Join(m.Errors...).Error() | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo:
checkToDateDescription
->checkUpToDateDescription