Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check deactivated plans in instances without pending upgrade #119

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

zucchinidev
Copy link
Contributor

@zucchinidev zucchinidev commented Dec 13, 2023

#186597655

Checklist:

Copy link
Member

@pivotal-marcela-campo pivotal-marcela-campo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! just suggesting a different variable name for readability.

internal/upgrader/upgrader.go Outdated Show resolved Hide resolved
internal/upgrader/upgrader.go Outdated Show resolved Hide resolved
internal/upgrader/upgrader.go Outdated Show resolved Hide resolved
internal/upgrader/upgrader.go Outdated Show resolved Hide resolved
@pivotal-marcela-campo pivotal-marcela-campo merged commit d325bff into main Dec 14, 2023
6 checks passed
@pivotal-marcela-campo pivotal-marcela-campo deleted the check_deactivated_plans_186597655 branch December 14, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants