Skip to content

Commit

Permalink
chore: apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
pivotal-marcela-campo committed Dec 14, 2023
1 parent 8f67281 commit d523560
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions internal/upgrader/upgrader.go
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ func performDryRun(upgradableInstances []ccapi.ServiceInstance, log Logger) erro
}

func discoverInstancesWithPendingUpgrade(log Logger, serviceInstances []ccapi.ServiceInstance) []ccapi.ServiceInstance {
var ii []ccapi.ServiceInstance
var instancesWithPendingUpgrade []ccapi.ServiceInstance
for _, i := range serviceInstances {
if !i.UpgradeAvailable {
continue
Expand All @@ -166,8 +166,8 @@ func discoverInstancesWithPendingUpgrade(log Logger, serviceInstances []ccapi.Se
continue
}

ii = append(ii, i)
instancesWithPendingUpgrade = append(instancesWithPendingUpgrade, i)
}

return ii
return instancesWithPendingUpgrade
}

0 comments on commit d523560

Please sign in to comment.