[1.11] Autodetect Chromium too (#597)

* autodetect Chromium Previosly only google-chrome was detected, that's a nuisance for people who have Chromium installed but not Google Chrome. * StyleCI
chrome-php · Mar 17, 2024 · 8288867 · 8288867
1 parent c1d78d3
commit 8288867
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/AutoDiscover.php b/src/AutoDiscover.php
@@ -40,7 +40,7 @@ public function guessChromeBinaryPath(): string
             case 'Windows':
                 return self::getFromRegistry() ?? '%ProgramFiles(x86)%\Google\Chrome\Application\chrome.exe';
             default:
-                return null === self::shellExec('command -v google-chrome') ? 'chrome' : 'google-chrome';
+                return \rtrim(\explode("\n", (string) self::shellExec('command -v google-chrome chromium-browser chrome chromium'), 2)[0]) ?: 'chrome';
         }
     }
 

diff --git a/tests/AutoDiscoverTest.php b/tests/AutoDiscoverTest.php
@@ -61,7 +61,9 @@ public function testLinux(): void
             $autoDiscover->guessChromeBinaryPath(),
             $this->logicalOr(
                 'chrome',
-                'google-chrome'
+                '/usr/bin/google-chrome',
+                '/usr/bin/chromium-browser',
+                '/snap/bin/chromium'
             )
         );
     }