Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add warning about java options #357

Merged
merged 1 commit into from
Sep 9, 2023
Merged

chore: add warning about java options #357

merged 1 commit into from
Sep 9, 2023

Conversation

chezou
Copy link
Owner

@chezou chezou commented Sep 9, 2023

Follow up for #356

Description

Add warning and documentation about java_options and jpype's shutdownJVM limitation.

Motivation and Context

Better developer's experience.

How Has This Been Tested?

Mostly document update.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I read the contributing document.
  • My code follows the code style of this project with running linter.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@chezou chezou merged commit 4f3652f into master Sep 9, 2023
2 checks passed
@chezou chezou deleted the java_options-doc branch September 9, 2023 05:13
@chezou chezou mentioned this pull request Sep 10, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chezou