fix(ui): Fixes V1 Run detail unnecessary reloading. Fixes kubeflow#10590

(kubeflow#11214) Signed-off-by: Jack Quinn <jack@jq.codes>
chensun · Sep 16, 2024 · eee095e · eee095e
1 parent 1a4849a
commit eee095e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/frontend/src/pages/RunDetails.tsx b/frontend/src/pages/RunDetails.tsx
@@ -101,6 +101,7 @@ interface SelectedNodeDetails {
 
 // exported only for testing
 export interface RunDetailsInternalProps {
+  isLoading?: boolean;
   runId?: string;
   gkeMetadata: GkeMetadata;
 }
@@ -237,6 +238,10 @@ class RunDetails extends Page<RunDetailsInternalProps, RunDetailsState> {
   }
 
   public render(): JSX.Element {
+    if (this.props.isLoading) {
+      return <div>Currently loading run information</div>;
+    }
+
     const {
       allArtifactConfigs,
       allowCustomVisualizations,

diff --git a/frontend/src/pages/RunDetailsRouter.tsx b/frontend/src/pages/RunDetailsRouter.tsx
@@ -70,9 +70,5 @@ export default function RunDetailsRouter(props: RunDetailsProps) {
     }
   }
 
-  if (runIsFetching || templateStrIsFetching) {
-    return <div>Currently loading run information</div>;
-  }
-
-  return <EnhancedRunDetails {...props} />;
+  return <EnhancedRunDetails {...props} isLoading={runIsFetching || templateStrIsFetching} />;
 }