chore: replace NMTProof with Proof in nmt #1432
Open
+144
−455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eoous
requested review from
cmwaters and
ninabarbakadze
and removed request for
a team
|
Currently it's not possible to exclude files via |
Eoous
force-pushed
the
duplicate-nmt-proof
branch
from
20272e8
to
aea3118
Compare
I have replaced it and need to review |
rach-id
reviewed
Sep 21, 2024
| @@ -0,0 +1,22 @@ | |||
| syntax="proto3"; | |||
There was a problem hiding this comment.
I think the idea is to import the proto file from the nmt repository: https://github.com/celestiaorg/nmt/blob/main/pb/proof.proto instead of copy pasting the definition here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use Proof in nmt instead of NMTProof.
Changed
Makefilefor removing protobuf file generated by buf.Resolves #1429
PR checklist
.changelog(we useunclog to manage our changelog)
docs/orspec/) and code comments