Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotations from info on default constructor #699

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

HGuillemet
Copy link
Contributor

When an info defines an annotation on a constructor, it's applied to the allocate() native method.
However, this works only if the C++ headers defines an explicit constructor. The info is ignored for default constructors.

This PR fixes that.

No changes in existing presets but in Pytorch: 10 modules (SigmoidImpl...) don't have explicit constructors.

@saudet saudet merged commit 283e87a into bytedeco:master Aug 8, 2023
11 checks passed
@HGuillemet HGuillemet deleted the annotation_default_constructor branch January 1, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants