Make the Tail call conv follow the system call conv for the return area ptr #9287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
force-pushed
the
abi_cleanup5
branch
2 times, most recently
from
5efc511
to
7459dfb
Compare
…ea ptr And for Winch make it follow the system call conv on all targets except aarch64 where the first regular argument register is used instead of the designated register.
bjorn3
force-pushed
the
abi_cleanup5
branch
from
7459dfb
to
439fa7c
Compare
github-actions
bot
added
cranelift
Subscribe to Label Action
This issue or pull request has been labeled: "cranelift", "cranelift:area:aarch64", "cranelift:area:x64", "winch"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
fitzgen
approved these changes
Sep 20, 2024
Comment on lines
116
to
+122
| next_x_reg += 1; | ||
| } | ||
| Some(ABIArg::reg( | ||
| x_reg(x_start).to_real_reg().unwrap(), | ||
| I64, | ||
| ir::ArgumentExtension::None, | ||
| ir::ArgumentPurpose::Normal, | ||
| )) |
There was a problem hiding this comment.
This really needs to be the first argument register. If next_x_reg - 1 is not x_start at this point, that is a bug.
bjorn3
force-pushed
the
abi_cleanup5
branch
from
47fcf3e
to
7e163b2
Compare
fitzgen
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.