Adjust exporter App Layer log output #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 1/N app layer logs are emitted _after_ the layers have been added. This can sometimes be an expensive operation depending on the layer size and export target. When trying to understand performance during builds, this wording implies the previous log line before the app layers was responsible for the time between the log lines. Adjusting the wording will make it a bit clearer that the time between the two log lines includes both steps. Before: ```bash 03:50:00 Adding layer 'buildpacksio/lifecycle:launch.sbom' 03:51:00 Adding 5/5 app layer(s) ```` After: ```bash 03:50:00 Adding layer 'buildpacksio/lifecycle:launch.sbom' 03:51:00 Added 5/5 app layer(s) ```` If we are more interested in going the other direction, where we keep "Adding 1/N app layers" and emitting multiple times or something I'm happy to iterate. Signed-off-by: Jesse Brown <jabrown85@gmail.com>
natalieparellano
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The 1/N app layer logs are emitted after the layers have been added. This can sometimes be an expensive operation depending on the layer size and export target.
When trying to understand performance during builds, this wording implies the previous log line before the app layers was responsible for the time between the log lines. Adjusting the wording will make it a bit clearer that the time between the two log lines includes both steps.
Before:
03:50:00 Adding layer 'buildpacksio/lifecycle:launch.sbom' 03:51:00 Adding 5/5 app layer(s)After:
03:50:00 Adding layer 'buildpacksio/lifecycle:launch.sbom' 03:51:00 Added 5/5 app layer(s)Release notes
Adjust exporter App Layer log output
Context
If we are more interested in going the other direction, where we keep "Adding 1/N app layers" and emitting multiple times or something I'm happy to iterate.