Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix batchMatMul-opt pass bug #367

Closed
wants to merge 3 commits into from
Closed

fix batchMatMul-opt pass bug #367

wants to merge 3 commits into from

Conversation

ShiHaoGao
Copy link
Contributor

No description provided.

zhanghb97
zhanghb97 reviewed Aug 14, 2024
View reviewed changes
Copy link
Member

@zhanghb97 zhanghb97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MLIR files need FileCheck for ninja check-buddy, see MLIRConvolution cases for details.

BTW, the folder name change to BuddyMatmul

@ShiHaoGao
Copy link
Contributor Author

The result of ninja check-buddy remains failed, becase of -batchmatmul-optimize's bugs.

@zhanghb97
Copy link
Member

image It also fails existing Linalg cases. We need to dig deep to find the real reason.

@zhanghb97
Copy link
Member

FYI - I have fixed the bug: 7e796f6

@zhanghb97 zhanghb97 closed this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhanghb97 zhanghb97 zhanghb97 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShiHaoGao @zhanghb97