Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for attribute on label #34

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Conversation

lukaszsamson
Copy link
Contributor

@lukaszsamson lukaszsamson commented Sep 3, 2024

Summary by Sourcery

Add support for the 'for' attribute in the SaladUI.Label component to enhance its functionality.

New Features:

  • Add support for the 'for' attribute in the SaladUI.Label component.

Copy link

sourcery-ai bot commented Sep 3, 2024

Reviewer's Guide by Sourcery

This pull request adds support for the 'for' attribute on the label component in the SaladUI library. The change is implemented by including the 'for' attribute in the list of allowed global attributes for the label component.

File-Level Changes

Change Details Files
Added support for the 'for' attribute on the label component
  • Included 'for' in the list of allowed global attributes for the label component
  • Updated the attr :rest, :global, include: line to include the 'for' attribute
lib/salad_ui/label.ex

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lukaszsamson - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@bluzky bluzky merged commit b3095a6 into bluzky:main Sep 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants