fix: durations #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tomsons
force-pushed
the
main
branch
2 times, most recently
from
288e7fc
to
1224a89
Compare
|
Thanks for letting me know that these timestamps can be float. I'll leave some comments. |
blckngm
requested changes
Aug 18, 2023
| @@ -65,15 +68,16 @@ impl<T> Default for OneOrMany<T> { | |||
| } | |||
|
|
|||
| /// JWT Claims. | |||
| #[serde_as] | |||
There was a problem hiding this comment.
If we are using serde_with, we might as well use skip_serializing_none.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current claim deserialization uses a base64 decoder to decode the jwt string part. By default, the base64 library decodes timestamps aka u64 into f64 which causes Errors when deserializing a token that
iat,expetc with timestamps.What has been done: