feat: implement Clone for HeaderAndClaims #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bittrance
changed the title
blckngm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my Axum JWT verification middleware, I want to pass the validated JWT on to successive middlewares and handlers. This is done by adding it to the
request.extensions()type map. However, it requiresT: CloneandHeaderAndClaims<_>currently does not implementCloneso this is not directly possible.This PR implements the relevant
Clonewhich spares the minor inconvenience of having to put the JWT in anArc. A quick test indicates that this will grow the release rlib by 4 kbytes (current rlib is c:a 1.1 Mbytes). Not sure if this is a reasonable trade-off, but since I wrote and tested the code, I thought I'd put it up for consideration.