Added alert contacts data to getMonitor and getAllMonitors methods. #26
Conversation
ghost
mentioned this pull request
ghost
mentioned this pull request
|
Also added #23 |
| @@ -169,6 +170,19 @@ func (m *Monitor) UnmarshalJSON(data []byte) error { | |||
| raw[f] = v | |||
| } | |||
| } | |||
| // We don't need full AlertContact structure, we need only its ID | |||
There was a problem hiding this comment.
Well, if we're going to do this, we might as well define the proper struct!
There was a problem hiding this comment.
Proper struct defined for the Monitor (pkg/monitor.go). This was not changed. There we have
type Monitor struct {
...
AlertContacts []string `json:"alert_contacts,omitempty"`
...
}
And in the pkg/alert_contact.go we have
type AlertContact struct {
ID string `json:"id"`
...
}
There was a problem hiding this comment.
Sorry, I misunderstood your comment, then. I thought you were saying you weren't going to unmarshal the complete struct. Are you?
There was a problem hiding this comment.
Yes. We have a structure for AlertContact, and we have field AlertContacts (type []string) in Monitor structure. We don't need complete AlertContact struct in Monotor, that's why I used only AlertContact.Id.
May be I misunderstood your first question. What did you mean by
Well, if we're going to do this, we might as well define the proper struct!
There was a problem hiding this comment.
@bitfield Are you still remember about this?
There was a problem hiding this comment.
I haven't forgotten about this, but it needs a non-trivial amount of time to get my head back into this project and review your code properly. I'll try to get to it as soon as I can!
#25