tests for creating HTTPS, IMAP and custom port monitors #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitfield
requested changes
May 2, 2020
| got, err := client.CreateMonitor(create) | ||
| if err != nil { | ||
| t.Error(err) | ||
|
|
There was a problem hiding this comment.
Just a house style tip; I don't use blank lines within functions in this project.
|
|
||
| for _, tc := range tcs { | ||
| t.Run(tc.name, func(t *testing.T) { | ||
| t.Parallel() |
There was a problem hiding this comment.
Watch out, there's a subtle bug here: https://gist.github.com/posener/92a55c4cd441fc5e5e85f27bca008721
In fact, we just end up running the Custom port test four times, and none of the others.
| for _, tc := range tcs { | ||
| t.Run(tc.name, func(t *testing.T) { | ||
| t.Parallel() | ||
| client := New("dummy") |
There was a problem hiding this comment.
We should probably move the client setup outside the t.Run() function, shouldn't we?
Plan to look into addressing feedback during the next week. |
|
@mkrivoshein how are you getting on? Need any help? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21