Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize usage of autoconf macros #110

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Modernize usage of autoconf macros #110

merged 1 commit into from
Apr 30, 2024

Conversation

robert-scheck
Copy link
Contributor

When running autoreconf --install (also art of ./bootstrap), some warnings related to autoconf are raised:

$ autoreconf --install
aclocal: warning: couldn't open directory 'm4': No such file or directory
libtoolize: putting auxiliary files in '.'.
libtoolize: copying file './ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
libtoolize: copying file 'm4/libtool.m4'
libtoolize: copying file 'm4/ltoptions.m4'
libtoolize: copying file 'm4/ltsugar.m4'
libtoolize: copying file 'm4/ltversion.m4'
libtoolize: copying file 'm4/lt~obsolete.m4'
configure.ac:59: warning: The macro 'AC_PROG_CC_STDC' is obsolete.
configure.ac:59: You should run autoupdate.
./lib/autoconf/c.m4:1669: AC_PROG_CC_STDC is expanded from...
configure.ac:59: the top level
configure.ac:61: warning: The macro 'AC_PROG_LIBTOOL' is obsolete.
configure.ac:61: You should run autoupdate.
m4/libtool.m4:100: AC_PROG_LIBTOOL is expanded from...
configure.ac:61: the top level
configure.ac:22: installing './compile'
configure.ac:18: installing './config.guess'
configure.ac:18: installing './config.sub'
configure.ac:19: installing './install-sh'
configure.ac:19: installing './missing'
Makefile.am: installing './depcomp'
$ 

Running autoreconf --install with the suggested changes applied looks finally like this:

$ autoreconf --install
aclocal: warning: couldn't open directory 'm4': No such file or directory
libtoolize: putting auxiliary files in '.'.
libtoolize: copying file './ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
libtoolize: copying file 'm4/libtool.m4'
libtoolize: copying file 'm4/ltoptions.m4'
libtoolize: copying file 'm4/ltsugar.m4'
libtoolize: copying file 'm4/ltversion.m4'
libtoolize: copying file 'm4/lt~obsolete.m4'
configure.ac:22: installing './compile'
configure.ac:18: installing './config.guess'
configure.ac:18: installing './config.sub'
configure.ac:19: installing './install-sh'
configure.ac:19: installing './missing'
Makefile.am: installing './depcomp'
$ 

To avoid breaking builds of bgpq4 in maybe non-edge Linux distributions, I've also tested this change with both:

  • autoconf 2.72 (Fedora Rawhide, currently 41)
  • autoconf 2.69 (RHEL/CentOS 7)

Note that autoconf 2.69 was released in April 2012. When looking to Repology, autoconf >= 2.69 seems to be in all common non-EOL distributions out there.

@job job merged commit b631d43 into bgp:main Apr 30, 2024
5 checks passed
@robert-scheck robert-scheck deleted the autoconf branch May 1, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants