Skip to content

Commit

Permalink
Transport::available isn't used
Browse files Browse the repository at this point in the history
  • Loading branch information
bertmelis committed Mar 27, 2023
1 parent f13a01d commit d13cee3
Show file tree
Hide file tree
Showing 9 changed files with 0 additions and 23 deletions.
4 changes: 0 additions & 4 deletions src/Transport/ClientAsync.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,6 @@ size_t ClientAsync::write(const uint8_t* buf, size_t size) {
return client.write(reinterpret_cast<const char*>(buf), size);
}

int ClientAsync::available() {
return static_cast<int>(availableData); // availableData will never be large enough to cause an overflow
}

int ClientAsync::read(uint8_t* buf, size_t size) {
size_t willRead = std::min(size, availableData);
memcpy(buf, bufData, std::min(size, availableData));
Expand Down
1 change: 0 additions & 1 deletion src/Transport/ClientAsync.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ class ClientAsync : public Transport {
bool connect(IPAddress ip, uint16_t port) override;
bool connect(const char* host, uint16_t port) override;
size_t write(const uint8_t* buf, size_t size) override;
int available() override;
int read(uint8_t* buf, size_t size) override;
void stop() override;
bool connected() override;
Expand Down
6 changes: 0 additions & 6 deletions src/Transport/ClientPosix.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,6 @@ size_t ClientPosix::write(const uint8_t* buf, size_t size) {
return ::send(_sockfd, buf, size, 0);
}

int ClientPosix::available() {
uint8_t buf[EMC_POSIX_PEEK_SIZE];
int ret = ::recv(_sockfd, &buf, EMC_POSIX_PEEK_SIZE, MSG_DONTWAIT|MSG_PEEK);
return ret;
}

int ClientPosix::read(uint8_t* buf, size_t size) {
int ret = ::recv(_sockfd, buf, size, MSG_DONTWAIT);
/*
Expand Down
1 change: 0 additions & 1 deletion src/Transport/ClientPosix.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ class ClientPosix : public Transport {
bool connect(IPAddress ip, uint16_t port) override;
bool connect(const char* host, uint16_t port) override;
size_t write(const uint8_t* buf, size_t size) override;
int available() override;
int read(uint8_t* buf, size_t size) override;
void stop() override;
bool connected() override;
Expand Down
4 changes: 0 additions & 4 deletions src/Transport/ClientSecureSync.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,6 @@ size_t ClientSecureSync::write(const uint8_t* buf, size_t size) {
return client.write(buf, size);
}

int ClientSecureSync::available() {
return client.available();
}

int ClientSecureSync::read(uint8_t* buf, size_t size) {
return client.read(buf, size);
}
Expand Down
1 change: 0 additions & 1 deletion src/Transport/ClientSecureSync.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ class ClientSecureSync : public Transport {
bool connect(IPAddress ip, uint16_t port) override;
bool connect(const char* host, uint16_t port) override;
size_t write(const uint8_t* buf, size_t size) override;
int available() override;
int read(uint8_t* buf, size_t size) override;
void stop() override;
bool connected() override;
Expand Down
4 changes: 0 additions & 4 deletions src/Transport/ClientSync.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,6 @@ size_t ClientSync::write(const uint8_t* buf, size_t size) {
return client.write(buf, size);
}

int ClientSync::available() {
return client.available();
}

int ClientSync::read(uint8_t* buf, size_t size) {
return client.read(buf, size);
}
Expand Down
1 change: 0 additions & 1 deletion src/Transport/ClientSync.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ class ClientSync : public Transport {
bool connect(IPAddress ip, uint16_t port) override;
bool connect(const char* host, uint16_t port) override;
size_t write(const uint8_t* buf, size_t size) override;
int available() override;
int read(uint8_t* buf, size_t size) override;
void stop() override;
bool connected() override;
Expand Down
1 change: 0 additions & 1 deletion src/Transport/Transport.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ class Transport {
virtual bool connect(IPAddress ip, uint16_t port) = 0;
virtual bool connect(const char* host, uint16_t port) = 0;
virtual size_t write(const uint8_t* buf, size_t size) = 0;
virtual int available() = 0;
virtual int read(uint8_t* buf, size_t size) = 0;
virtual void stop() = 0;
virtual bool connected() = 0;
Expand Down

0 comments on commit d13cee3

Please sign in to comment.