Fix critical hours when O1A/O1B present #3947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3947 +/- ##
=======================================
Coverage 81.35% 81.35%
=======================================
Files 298 298
Lines 11421 11421
Branches 546 546
=======================================
Hits 9292 9292
Misses 2094 2094
Partials 35 35 ☔ View full report in Codecov by Sentry. |
conbrad
approved these changes
Sep 18, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fuel grid raster doesn't differentiate between O1A and O1B fuel types, it combines them as O1A/O1B. This joint fuel type doesn't exist in our FuelTypeEnum. Being unsure of the ramifications with cffdrs, after discussion with the PO we are treating O1A/O1B as O1B for the sake of calculating critical hours.
This PR also adds the ability to re-run critical hours processing by supplying a RunParameters.id.
Test Links:
Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator