Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASA Labels to DB #3910

Merged
merged 3 commits into from
Sep 11, 2024
Merged

ASA Labels to DB #3910

merged 3 commits into from
Sep 11, 2024

Conversation

brettedw
Copy link
Collaborator

@brettedw brettedw commented Sep 10, 2024

  • Adds placename_label column to advisory_shapes
  • Changes fire_shape_name from label to placename_label in the provincial summary used in ASA front end
  • Replaces fire zone names in ASA side panel with unique names, where there was some duplicates before eg. V1-Fraser Fire Zone
  • ASA side panel zone names match map labels

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.27%. Comparing base (65f48a9) to head (108305d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3910   +/-   ##
=======================================
  Coverage   81.26%   81.27%           
=======================================
  Files         294      294           
  Lines       11361    11362    +1     
  Branches      526      526           
=======================================
+ Hits         9233     9234    +1     
  Misses       2094     2094           
  Partials       34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Sep 11, 2024

@brettedw brettedw temporarily deployed to production September 11, 2024 15:25 Inactive
@brettedw brettedw merged commit 601d2a2 into main Sep 11, 2024
28 checks passed
@brettedw brettedw deleted the task/asa-db-labels branch September 11, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants