Skip to content

Commit

Permalink
Merge #156
Browse files Browse the repository at this point in the history
156: fix: fixed for the issue (#155) r=myConsciousness a=myConsciousness

# 1. Description

<!-- Provide a description of what this PR is doing.
If you're modifying existing behavior, describe the existing behavior, how this PR is changing it,
and what motivated the change. If this is a breaking change, specify explicitly which APIs have been
changed. -->

## 1.1. Checklist

<!-- Before you create this PR confirm that it meets all requirements listed below by checking the
relevant checkboxes (`[x]`). This will ensure a smooth and quick review process. -->

- [ ] The title of my PR starts with a [Conventional Commit] prefix (`fix:`, `feat:`, `docs:` etc).
- [ ] I have read the [Contributor Guide] and followed the process outlined for submitting PRs.
- [ ] I have updated/added tests for ALL new/updated/fixed functionality.
- [ ] I have updated/added relevant documentation in `docs` and added dartdoc comments with `///`.
- [ ] I have updated/added relevant examples in `examples`.

## 1.2. Breaking Change

<!-- Does your PR require batch.dart users to manually update their apps to accommodate your change?

If the PR is a breaking change this should be indicated with suffix "!"  (for example, `feat!:`, `fix!:`). See [Conventional Commit] for details.
-->

- [ ] Yes, this is a breaking change.
- [ ] No, this is _not_ a breaking change.

## 1.3. Related Issues

<!-- Provide a list of issues related to this PR from the [issue database].
Indicate which of these issues are resolved or fixed by this PR, i.e. Fixes #xxxx* !-->

<!-- Links -->

[issue database]: https://github.com/batch-dart/batch.dart/issues
[contributor guide]: https://github.com/batch-dart/batch.dart/blob/main/CONTRIBUTING.md
[batch.dart style guide]: https://github.com/batch-dart/batch.dart/blob/main/STYLEGUIDE.md
[conventional commit]: https://conventionalcommits.org


Co-authored-by: myConsciousness <kato.shinya.dev@gmail.com>
  • Loading branch information
bors[bot] and myConsciousness committed Apr 20, 2022
2 parents fa6a3e5 + 4acc2b4 commit e8065b5
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 9 deletions.
11 changes: 8 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
# Release Note

## v0.13.0

- `SkipConfiguration` and `RetryConfiguration` settings were limited to `Step` only. ([#145](https://github.com/batch-dart/batch.dart/issues/145))
## v1.0.0

- Made changes to the specifications to make it easier and safer to use the framework.
- The method of adding Tasks to Steps has been changed.
- Specify `Task` or `ParallelTask` in the constructor of `Step` or `ParallelStep`, not `registerStep` and `registerParallel`.
- The method to create branches are changed. Use`branchesOnSucceeded`, `branchesOnFailed`, `branchesOnCompleted` in the constructors of Events such as `Job` and `Step` instead of in the `createBranch...` methods.
- The method for setting up a job in `BatchApplication` has changed. Use the `nextSchedule` method instead of `addJob`. Also, pass a class that extends `ScheduledJobBuilder` to this `nextSchedule` method; the object that should be returned from `ScheduledJobBuilder` is `ScheduledJob`, which must be scheduled.
- `SkipConfiguration` and `RetryConfiguration` settings were limited to `Step` only. ([#145](https://github.com/batch-dart/batch.dart/issues/145))

## v0.12.2

Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -120,10 +120,10 @@ It is also easy to define a scheduled job: define a process to generate a `Sched
import 'package:batch/batch.dart';
void main() => BatchApplication()
..scheduleNext(SayHelloWorldJobBuilder())
..scheduleNext(SayHelloWorldJob())
..run();
class SayHelloWorldJobBuilder implements ScheduledJobBuilder {
class SayHelloWorldJob implements ScheduledJobBuilder {
@override
ScheduledJob build() => ScheduledJob(
name: 'Test Job',
Expand Down
2 changes: 1 addition & 1 deletion lib/src/banner/default_banner.dart
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class DefaultBanner implements Banner {
║ ╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╰━━╯ ║
║ ║
╠═════════════════════════════════════════════════════════════════════════╣
║ Version : ${Version.current} ║
║ Version : ${Version.current}
║ License : BSD 3-Clause ║
║ Author : Kato Shinya (https://github.com/myConsciousness) ║
╚═════════════════════════════════════════════════════════════════════════╝
Expand Down
2 changes: 1 addition & 1 deletion lib/src/version/version.dart
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ abstract class Version {
factory Version() => _Version();

/// The current version
static const current = '1.0.0-preview.1';
static const current = '1.0.0';

/// Returns the version status.
Future<VersionStatus> get status;
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: batch
description: A lightweight and powerful Job Scheduling Framework written in Dart. With this framework, you can easily develop a job scheduling and batch program in Dart.
version: 1.0.0-preview.1
version: 1.0.0
homepage: https://github.com/batch-dart/batch.dart

environment:
Expand Down
2 changes: 1 addition & 1 deletion test/src/banner/default_banner_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ const _builtBanner = '''
║ ╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╱╰━━╯ ║
║ ║
╠═════════════════════════════════════════════════════════════════════════╣
║ Version : 1.0.0-preview.1
║ Version : 1.0.0
║ License : BSD 3-Clause ║
║ Author : Kato Shinya (https://github.com/myConsciousness) ║
╚═════════════════════════════════════════════════════════════════════════╝
Expand Down

0 comments on commit e8065b5

Please sign in to comment.