Merge branch 'main' into remove_deprecated_fingerprint_function

basf · Sep 20, 2024 · b36f6ce · b36f6ce
2 parents 6b5a844 + 1f3d521
commit b36f6ce
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/.github/workflows/linting.yml b/.github/workflows/linting.yml
@@ -22,7 +22,7 @@ jobs:
         pip install pylint
     - name: Analysing the code with pylint
       run: |
-        pylint  -d C0301,R0913,W1202 $(git ls-files '*.py') --ignored-modules "rdkit"
+        pylint  -d C0301,R0913,W1202 $(git ls-files '*.py') --ignored-modules "rdkit"  --max-positional-arguments 10
   mypy:
     runs-on: ubuntu-latest
     steps:

diff --git a/molpipeline/estimators/chemprop/component_wrapper.py b/molpipeline/estimators/chemprop/component_wrapper.py
@@ -151,7 +151,7 @@ class PredictorWrapper(_Predictor, BaseEstimator, abc.ABC):  # type: ignore
     _T_default_criterion: LossFunction
     _T_default_metric: Metric
 
-    def __init__(
+    def __init__(  # pylint: disable=too-many-positional-arguments
         self,
         n_tasks: int = 1,
         input_dim: int = DEFAULT_HIDDEN_DIM,
@@ -327,7 +327,7 @@ class MulticlassClassificationFFN(PredictorWrapper, _MulticlassClassificationFFN
     _T_default_criterion = CrossEntropyLoss
     _T_default_metric = CrossEntropyMetric
 
-    def __init__(
+    def __init__(  # pylint: disable=too-many-positional-arguments
         self,
         n_classes: int,
         n_tasks: int = 1,

diff --git a/molpipeline/mol2any/mol2path_fingerprint.py b/molpipeline/mol2any/mol2path_fingerprint.py
@@ -27,7 +27,7 @@ class Mol2PathFP(
 
     """
 
-    # pylint: disable=too-many-arguments,too-many-locals
+    # pylint: disable=too-many-arguments,too-many-locals,too-many-positional-arguments
     def __init__(
         self,
         min_path: int = 1,