Issue #32: Fix broken views preview (#33)

backdrop-contrib · Sep 6, 2023 · 8b75bbb · 8b75bbb
1 parent ded6e11
commit 8b75bbb
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 4 deletions.
diff --git a/.github/phpstan/baseline.neon b/.github/phpstan/baseline.neon
@@ -5,6 +5,16 @@ parameters:
 			count: 1
 			path: ../../fullcalendar_views.module
 
+		-
+			message: "#^Function fullcalendar_views_preprocess_page\\(\\) has no return type specified\\.$#"
+			count: 1
+			path: ../../fullcalendar_views.module
+
+		-
+			message: "#^Function fullcalendar_views_preprocess_page\\(\\) has parameter \\$variables with no type specified\\.$#"
+			count: 1
+			path: ../../fullcalendar_views.module
+
 		-
 			message: "#^Function fullcalendar_views_preprocess_views_ui_view_preview_section\\(\\) has no return type specified\\.$#"
 			count: 1

diff --git a/fullcalendar_views.module b/fullcalendar_views.module
@@ -46,6 +46,23 @@ function fullcalendar_views_preprocess_views_ui_view_preview_section(&$variables
   }
 }
 
+/**
+ * Implements hook_preprocess_HOOK().
+ */
+function fullcalendar_views_preprocess_page(&$variables) {
+  // Inject js and css for calendar previews on every potential candidate, even
+  // if not needed.
+  // @todo is there a smarter way (without breaking ajax)?
+  $pattern = '#admin/structure/views/view/.+/configure/page#';
+  $path = current_path();
+  if (preg_match($pattern, $path) === 1) {
+    $module_path = backdrop_get_path('module', 'fullcalendar_views');
+    backdrop_add_library('fullcalendar_lib', 'fullcalendar');
+    backdrop_add_js($module_path . '/js/fullcalendar-views.js');
+    backdrop_add_css($module_path . '/css/fullcalendar-views.css');
+  }
+}
+
 /**
  * Helper function to return supported field API types.
  *

diff --git a/views/fullcalendar_views_style_calendar.inc b/views/fullcalendar_views_style_calendar.inc
@@ -287,10 +287,15 @@ class FullcalendarViewsStyleCalendar extends views_plugin_style {
       backdrop_add_library('system', 'ui.tooltip');
       $settings['hasTooltips'] = TRUE;
     }
-    $module_path = backdrop_get_path('module', 'fullcalendar_views');
-    backdrop_add_library('fullcalendar_lib', 'fullcalendar');
-    backdrop_add_js($module_path . '/js/fullcalendar-views.js');
-    backdrop_add_css($module_path . '/css/fullcalendar-views.css');
+
+    // The ajax preview breaks when adding those in live preview.
+    // @see views_fullcalendar_preprocess_page
+    if (empty($this->view->live_preview)) {
+      $module_path = backdrop_get_path('module', 'fullcalendar_views');
+      backdrop_add_library('fullcalendar_lib', 'fullcalendar');
+      backdrop_add_js($module_path . '/js/fullcalendar-views.js');
+      backdrop_add_css($module_path . '/css/fullcalendar-views.css');
+    }
 
     $id = $view->name . ucfirst($view->current_display);
     $setup = array(