Skip to content

Commit

Permalink
Improved S3 progress callback (#666)
Browse files Browse the repository at this point in the history 
Update to latest submodules. This gets us the improved S3 progress callbacks, which now fire for every meta-request type, and no longer overlap. See: awslabs/aws-c-s3#344

```
aws-c-auth         v0.7.2 -> v0.7.3
aws-c-cal          v0.6.1 -> v0.6.2
aws-c-common       v0.9.0 -> v0.9.1
aws-c-event-stream v0.3.1 -> v0.3.2
aws-c-http         v0.7.11 -> v0.7.12
aws-c-io           v0.13.31 -> v0.13.32
aws-c-mqtt         v0.9.3 -> v0.9.5
aws-c-s3           v0.3.14 -> v0.3.16
aws-lc             v1.13.0 -> v1.14.0
s2n                v1.3.48 -> v1.3.50
```
  • Loading branch information
@graebm
graebm committed Aug 26, 2023
1 parent 2418b06 commit 1271b25
Show file tree
Hide file tree
Showing 11 changed files with 15 additions and 12 deletions.
2 changes: 1 addition & 1 deletion crt/aws-c-auth
Submodule aws-c-auth updated 2 files
+0 −1 include/aws/auth/credentials.h
+1 −3 source/credentials_provider_process.c
2 changes: 1 addition & 1 deletion crt/aws-c-cal
Submodule aws-c-cal updated 4 files
+0 −9 CMakeLists.txt
+1 −1 bin/produce_x_platform_fuzz_corpus/CMakeLists.txt
+1 −1 bin/run_x_platform_fuzz_corpus/CMakeLists.txt
+1 −1 bin/sha256_profile/CMakeLists.txt
2 changes: 1 addition & 1 deletion crt/aws-c-common
Submodule aws-c-common updated 37 files
+1 −1 .clang-tidy
+1 −1 .github/workflows/clang-tidy.yml
+3 −0 .github/workflows/stale_issue.yml
+4 −1 CMakeLists.txt
+36 −0 THIRD-PARTY-LICENSES.txt
+7 −0 cmake/AwsCFlags.cmake
+1 −1 include/aws/common/allocator.h
+1 −1 include/aws/common/array_list.h
+4 −2 include/aws/common/date_time.h
+68 −61 include/aws/common/external/cJSON.h
+4,668 −0 include/aws/common/external/ittnotify.h
+5 −3 include/aws/common/hash_table.h
+3 −1 include/aws/common/logging.h
+1 −1 include/aws/common/macros.h
+4 −1 include/aws/common/statistics.h
+1 −1 include/aws/common/uuid.h
+4 −4 source/allocator.c
+2 −2 source/allocator_sba.c
+3 −3 source/date_time.c
+1 −1 source/encoding.c
+2,381 −2,371 source/external/cJSON.c
+1 −1 source/hash_table.c
+9 −7 source/log_formatter.c
+1 −1 source/logging.c
+1 −1 source/memtrace.c
+2 −2 source/posix/clock.c
+2 −4 source/posix/condition_variable.c
+2 −1 source/posix/device_random.c
+5 −3 source/posix/mutex.c
+2 −2 source/posix/system_info.c
+1 −1 source/posix/thread.c
+1 −1 source/process_common.c
+3 −3 source/thread_scheduler.c
+1 −1 source/thread_shared.c
+1 −1 source/windows/system_info.c
+8 −8 tests/math_test.c
+18 −18 tests/uri_test.c
2 changes: 1 addition & 1 deletion crt/aws-c-event-stream
Submodule aws-c-event-stream updated 1 files
+2 −2 bin/CMakeLists.txt
2 changes: 1 addition & 1 deletion crt/aws-c-http
Submodule aws-c-http updated 1 files
+1 −1 bin/elasticurl/CMakeLists.txt
2 changes: 1 addition & 1 deletion crt/aws-c-io
Submodule aws-c-io updated 6 files
+3 −0 .github/workflows/stale_issue.yml
+2 −0 include/aws/io/io.h
+2 −3 source/darwin/secure_transport_tls_channel_handler.c
+4 −0 source/io.c
+17 −2 source/s2n/s2n_tls_channel_handler.c
+3 −3 source/windows/secure_channel_tls_handler.c
2 changes: 1 addition & 1 deletion crt/aws-c-mqtt
Submodule aws-c-mqtt updated 14 files
+1 −1 bin/elastipubsub/CMakeLists.txt
+1 −1 bin/elastipubsub5/CMakeLists.txt
+1 −1 bin/mqtt5canary/CMakeLists.txt
+18 −0 include/aws/mqtt/client.h
+2 −0 include/aws/mqtt/private/client_impl.h
+5 −0 include/aws/mqtt/private/client_impl_shared.h
+3 −0 include/aws/mqtt/private/v5/mqtt5_to_mqtt3_adapter_impl.h
+31 −0 source/client.c
+9 −0 source/client_impl_shared.c
+11 −36 source/v5/mqtt5_client.c
+82 −0 source/v5/mqtt5_to_mqtt3_adapter.c
+3 −0 tests/CMakeLists.txt
+55 −0 tests/v3/connection_state_test.c
+21 −0 tests/v5/mqtt5_to_mqtt3_adapter_tests.c
2 changes: 1 addition & 1 deletion crt/aws-c-s3
Submodule aws-c-s3 updated 22 files
+18 −0 .github/workflows/handle-stale-discussions.yml
+0 −7 CMakeLists.txt
+3 −1 include/aws/s3/private/s3_auto_ranged_get.h
+52 −4 include/aws/s3/private/s3_meta_request_impl.h
+2 −2 include/aws/s3/private/s3_request.h
+1 −1 include/aws/s3/private/s3_util.h
+6 −1 include/aws/s3/s3_client.h
+1 −1 samples/s3/CMakeLists.txt
+21 −3 source/s3_auto_ranged_get.c
+24 −7 source/s3_auto_ranged_put.c
+4 −6 source/s3_client.c
+20 −4 source/s3_copy_object.c
+23 −0 source/s3_default_meta_request.c
+168 −166 source/s3_endpoint_resolver/aws_s3_endpoint_resolver_partition.c
+2,817 −4,814 source/s3_endpoint_resolver/aws_s3_endpoint_rule_set.c
+156 −65 source/s3_meta_request.c
+9 −9 source/s3_request.c
+2 −2 source/s3_util.c
+114 −85 tests/s3_data_plane_tests.c
+5 −12 tests/s3_mock_server_tests.c
+43 −24 tests/s3_tester.c
+5 −4 tests/s3_tester.h
2 changes: 1 addition & 1 deletion crt/aws-lc
Submodule aws-lc updated from 05fc08 to 9b323d
2 changes: 1 addition & 1 deletion crt/s2n
Submodule s2n updated from 65e74c to baf094
7 changes: 5 additions & 2 deletions src/main/java/software/amazon/awssdk/crt/s3/S3MetaRequestResponseHandler.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,11 @@ default void onFinished(S3FinishedResponseContext context) {

/**
* Invoked to report progress of the meta request execution.
* Currently, the progress callback is invoked only for the CopyObject and PutObject meta request type.
* TODO: support this callback for all types of meta requests
* The meaning of "progress" depends on the {@link S3MetaRequestOptions.MetaRequestType}.
* For PUT_OBJECT, it refers to bytes uploaded.
* For COPY_OBJECT, it refers to bytes copied.
* For GET_OBJECT, it refers to bytes downloaded.
* For anything else, it refers to response body bytes received.
* @param progress information about the progress of the meta request execution
*/
default void onProgress(final S3MetaRequestProgress progress) {
Expand Down

0 comments on commit 1271b25

Please sign in to comment.