Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: release alpn string before set for tls_ctx_options #588

Merged
merged 3 commits into from
Aug 3, 2023

Conversation

xiazhvera
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f7bc831) 79.94% compared to head (13fe790) 79.94%.

❗ Current head 13fe790 differs from pull request most recent head 12779df. Consider uploading reports for the commit 12779df to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #588   +/-   ##
=======================================
  Coverage   79.94%   79.94%           
=======================================
  Files          27       27           
  Lines        5844     5845    +1     
=======================================
+ Hits         4672     4673    +1     
  Misses       1172     1172           
Files Changed Coverage Δ
source/tls_channel_handler.c 62.96% <100.00%> (+0.15%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

source/tls_channel_handler.c Outdated Show resolved Hide resolved
xiazhvera and others added 2 commits August 2, 2023 14:58
Co-authored-by: Dengke Tang <dengket@amazon.com>
@xiazhvera xiazhvera merged commit a3555c8 into main Aug 3, 2023
32 checks passed
@xiazhvera xiazhvera deleted the ctx_options_fix branch August 3, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants