Gitops 2857 fix kuttl test parallel 055 #940
Open
+516
−204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciiay
force-pushed
the
gitops-2857-fix-kuttl-test-parallel-055
branch
2 times, most recently
from
abb5d68
to
9228363
Compare
ciiay
force-pushed
the
gitops-2857-fix-kuttl-test-parallel-055
branch
2 times, most recently
from
a4524cc
to
62f2a54
Compare
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
…ds (argoproj-labs#896) * Remove deprecated dex & sso fields Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * Unify .status.sso Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * Add unit test for .status.sso unification Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * Add & fix e2e tests for unified status.sso Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * make bundle Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * Fix make bundle codegen ci failure Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * Fix keycloak status reconciliation Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * Case insensitive sso provider check Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * Do not block reconciliation due to sso failures SSO is a non-critical component and we shouldn't block reconciliation on its failure Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * Remove extra .ToLower() calls on already defined sso value Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * Remove envVar & setEnvVarFunc feilds from dex unit tests There are a lot of unit tests that have envVar & setEnvVarFunc field that was required for DISABLE_DEX testing. These fields are not required in these tests anymore. Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * Fix ci failure Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> --------- Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> Signed-off-by: Yi Cai <yicai@redhat.com>
* Update docs to reflect sso unification changes Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * Add a note about removed sso fields Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> --------- Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Fix typo in trigger on-sync-status-unknown for argocd-notifications-cm configMap. Signed-off-by: Sirbu, Cristina <sirbucristina.is@gmail.com> Signed-off-by: Sirbu, Cristina <Cristina.Sirbu@garmin.com> --------- Signed-off-by: Arthur <arthur@arthurvardevanyan.com> Signed-off-by: Sirbu, Cristina <Cristina.Sirbu@garmin.com> Signed-off-by: Sirbu, Cristina <sirbucristina.is@gmail.com> Co-authored-by: Arthur Vardevanyan <arthur@arthurvardevanyan.com> Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
ciiay
force-pushed
the
gitops-2857-fix-kuttl-test-parallel-055
branch
from
9e26139
to
7196cb4
Compare
…uttl-test-parallel-055
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed off: @ciiay
What type of PR is this?
/kind bug
What does this PR do / why we need it:
For flaky kuttl test 1-055_validate_notification_controller
When notifications controller deployment was getting deleted, it got this error
Major updates for best practice:
Moved cr.Spec.Notifications.Enabled condition check from each resource reconciliation function into higher-level function, reconcileResources
Split the original resource reconcile function into two functions. One for reconciliation, another one for deletion.
Removed deletion from deleteNotificationsPred function, so that it's purely for predication of Notifications.Enabled value change.
Which issue(s) this PR fixes:
Fixes #? GITOPS-2857
How to test changes / Special notes to the reviewer:
kuttl test parallel/1-055_validate_notification_controller shouldn't be flaky or fail anymore. This PR works along with redhat-developer/gitops-operator#527 which adds teststep to wait for notification controller pod to be ready.
Note:
Corresponding test case doesn't need to change. This only adds a not found check before executing deletion of service account. I tried to update the test case, but since it's a race condition issue, deployment and rolebinding instance will always be deleted first before reconcile function deletes the service account.