Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1-014_validate_parallelism_limit for local test #929

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ciiay
Copy link
Collaborator

@ciiay ciiay commented Jun 8, 2023

What type of PR is this?

/kind bug

What does this PR do / why we need it:
This PR fixes 1-014_validate_parallelism_limit failure. When run this test locally, it shows below error in logs.

logger.go:42: 15:31:37 | 1-014_validate_parallelism_limit/2-check-deployment | grep: invalid option -- P
logger.go:42: 15:31:37 | 1-014_validate_parallelism_limit/2-check-deployment | usage: grep [-abcdDEFGHhIiJLlMmnOopqRSsUVvwXxZz] [-A num] [-B num] [-C[num]]
logger.go:42: 15:31:37 | 1-014_validate_parallelism_limit/2-check-deployment |      [-e pattern] [-f file] [--binary-files=value] [--color=when]
logger.go:42: 15:31:37 | 1-014_validate_parallelism_limit/2-check-deployment |      [--context[=num]] [--directories=action] [--label] [--line-buffered]
logger.go:42: 15:31:37 | 1-014_validate_parallelism_limit/2-check-deployment |      [--null] [pattern] [file ...]
logger.go:42: 15:31:37 | 1-014_validate_parallelism_limit/2-check-deployment | Incorrect or missing --kubectl-parallelism-limit detected.
logger.go:42: 15:31:37 | 1-014_validate_parallelism_limit/2-check-deployment | argocd-application-controller
logger.go:42: 15:31:37 | 1-014_validate_parallelism_limit/2-check-deployment | --operation-processors
logger.go:42: 15:31:37 | 1-014_validate_parallelism_limit/2-check-deployment | 10
logger.go:42: 15:31:37 | 1-014_validate_parallelism_limit/2-check-deployment | --redis
logger.go:42: 15:31:37 | 1-014_validate_parallelism_limit/2-check-deployment | argocd-redis.kuttl-test-intimate-yeti.svc.cluster.local:6379
logger.go:42: 15:31:37 | 1-014_validate_parallelism_limit/2-check-deployment | --repo-server
logger.go:42: 15:31:37 | 1-014_validate_parallelism_limit/2-check-deployment | argocd-repo-server.kuttl-test-intimate-yeti.svc.cluster.local:8081
logger.go:42: 15:31:37 | 1-014_validate_parallelism_limit/2-check-deployment | --status-processors
logger.go:42: 15:31:37 | 1-014_validate_parallelism_limit/2-check-deployment | 20
logger.go:42: 15:31:37 | 1-014_validate_parallelism_limit/2-check-deployment | --kubectl-parallelism-limit
logger.go:42: 15:31:37 | 1-014_validate_parallelism_limit/2-check-deployment | 10
logger.go:42: 15:31:37 | 1-014_validate_parallelism_limit/2-check-deployment | --loglevel
logger.go:42: 15:31:37 | 1-014_validate_parallelism_limit/2-check-deployment | info
logger.go:42: 15:31:37 | 1-014_validate_parallelism_limit/2-check-deployment | --logformat
logger.go:42: 15:31:37 | 1-014_validate_parallelism_limit/2-check-deployment | text
case.go:364: failed in step 2-check-deployment

This PR fixes the unsupported grep option issue and makes sure it passes test locally.

Signed-off-by: Yi Cai <yicai@redhat.com>
@ciiay ciiay force-pushed the fix-014-valdidate-parallelism-limit-test branch from 3fb86de to 1f90914 Compare June 8, 2023 19:55
@ciiay ciiay changed the title [WIP] Fix 014 test Fix 1-014_validate_parallelism_limit for local test Jun 8, 2023
@ciiay
Copy link
Collaborator Author

ciiay commented Jun 17, 2023

Hi @varshab1210 , can you take a look at this PR? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant