Add support for multiarch images, include ARM64 #1453
Conversation
Signed-off-by: Lee Ween Jiann <16207788+lwj5@users.noreply.github.com>
lwj5
changed the title
|
Hope you can help review |
|
Hi @lwj5 , thanks for the PR. I will try to get to it in next few days. |
|
Any updates or feedback would be good |
| cache-from: type=gha | ||
| cache-to: type=gha,mode=max |
There was a problem hiding this comment.
What is the purpose of this?
There was a problem hiding this comment.
This exports and retrieves docker build cache to GitHub cache to speed up build time if certain layers have not changed.
https://docs.docker.com/reference/cli/docker/buildx/build/#cache-to
on your local host, this is done transparently. Hence why the 2nd docker build is slightly faster
| FROM golang:1.21 as builder | ||
| FROM --platform=$BUILDPLATFORM golang:1.21 as builder | ||
|
|
||
| ARG TARGETOS TARGETARCH |
There was a problem hiding this comment.
These variables are not set anywhere. What are their default values? Are these specific to Docker? Can we remove them?
There was a problem hiding this comment.
These arg are auto populated if not specified. They default to the local platform.
https://docs.docker.com/reference/dockerfile/#automatic-platform-args-in-the-global-scope
They are required for the multi arch build used in the go build line
| @@ -1,5 +1,7 @@ | |||
| # Build the manager binary | |||
| FROM golang:1.21 as builder | |||
| FROM --platform=$BUILDPLATFORM golang:1.21 as builder | |||
There was a problem hiding this comment.
I assume $BUILDPLATFORM will default to the arch on which the build is running on if not set. Can you confirm if make docker-build runs fine and local dev builds are not impacted with this change?
There was a problem hiding this comment.
Yes this will default to the local platform it is running on.
There is no difference to local builds. They work as-is like previously
What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
Support for building ARM64 images
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
How to test changes / Special notes to the reviewer:
I see a set up go and go cache here, but doesn't seem to be used
argocd-operator/.github/workflows/publish.yaml
Line 22 in e5872c5
If you would like, E2E tests can be added for macOS runner to test arm64