feat: Add option to customize in-cluster name #1154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
This PR introduces a method to specify the cluster name for Argo CD deployments. Previously, it defaulted to
in-cluster
.Our team creates templates for other DevOps teams in our company. One such template deploys the primary Argo CD instance in the production cluster, along with mock instances in testing and external clusters. These instances are labeled "in-cluster," "testing," and "external." This labeling has caused confusion due to the absence of a "production" label. Renaming "in-cluster" to "production" will resolve this issue.
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #1093
How to test changes / Special notes to the reviewer:
Deploy the ArgoCD custom resource below and confirm that
example-cluster
is set as the name in theexample-argocd-default-cluster-config
secret.