Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code-refactoring: Replace ArgoCD v1alpha1 references with v1beta1 #1003

Merged

Conversation

svghadi
Copy link
Collaborator

@svghadi svghadi commented Sep 20, 2023

What type of PR is this?
/kind code-refactoring

What does this PR do / why we need it:
Follow up PR for #999 to replace v1alpha1 references of ArgoCD to v1beta1 in operator-redesign branch.

Change:
Update the ArgoCD API import path & references to use

  • argoproj for v1beta1
  • argoprojv1alpha1 for v1alpha1

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
@svghadi
Copy link
Collaborator Author

svghadi commented Oct 6, 2023

Most of the changes have already been added to the redesign branch with #1010. However, a few changes are still pending.

@svghadi svghadi requested a review from ciiay October 6, 2023 05:43
Copy link
Collaborator

@ciiay ciiay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Siddhesh, all changes look good to me. I only found this one didn't change, is this left on purpose?

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
@svghadi
Copy link
Collaborator Author

svghadi commented Oct 6, 2023

Oops, missed it. Thanks for pointing it out. - @ciiay
Updated the PR.

Copy link
Collaborator

@ciiay ciiay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks 👍

@svghadi svghadi merged commit 5d6261d into argoproj-labs:operator-redesign Oct 6, 2023
1 of 3 checks passed
@svghadi svghadi deleted the redesign-v1beta1-ref branch October 6, 2023 14:51
Julik24 pushed a commit to Julik24/argocd-operator that referenced this pull request Apr 24, 2024
…goproj-labs#1003)

* Replace ArgoCD v1alpha1 references with v1beta1

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>

* Update alpha ref in keycloak.go

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>

---------

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants