Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract all bindings and support multiple certificates when decoding idp metadata #26

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

kmacgugan
Copy link

Extract all bindings when decoding idp metadata.

-Before, this would only look for HTTP-POST login locations. Now, it will
extract any location it finds: post, redirect, or artifact. The way this
is achieved is not the most beautiful, but allows for easy matching when
#esaml_idp_metadata is used.

Support multiple certificates from idp metadata.

-Changes the esaml_idp_metadata record: certificate -> certificates,
now of type [binary()] instead of binary(), with undefined instead
of [] winning if there's nothing in the metadata xml document.

Adds okta-ish and azure test metadata.

Before, this would only look for HTTP-POST login locations. Now, it will
extract any location it finds: post, redirect, or artifact. The way this
is achieved is not the most beautiful, but allows for easy matching when
`#esaml_idp_metadata` is used.

Also adds okta-ish test metadata.
Changes the `esaml_idp_metadata` record: `certificate` -> `certificates`,
now of type `[binary()]` instead of `binary()`, with `undefined` instead
of `[]` winning if there's nothing in the metadata xml document.

Test data included (Azure AD).
@kmacgugan kmacgugan changed the title Multiple certificates Extract all bindings and support multiple certificates when decoding idp metadata Jun 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants