Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved compile speed by running multi-threaded library discovery. #2625

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

Improved compile speed by running multi-threaded library discovery. #2625

wants to merge 28 commits into from

Commits on Aug 8, 2024

  1. Removed unused field/parameter

    @cmaglie
    cmaglie committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    6eb7b61 View commit details
    Browse the repository at this point in the history

  2. Moved Result structure into his own package 

    This change is preparatory for next refactorings
    @cmaglie
    cmaglie committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    b4262e0 View commit details
    Browse the repository at this point in the history

  3. Moving sourceFile object in his own file

    @cmaglie
    cmaglie committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    3daa69f View commit details
    Browse the repository at this point in the history

  4. Moved uniqueSourceFileQueue in his own file

    @cmaglie
    cmaglie committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    5fc9a84 View commit details
    Browse the repository at this point in the history

  5. Moved includeCache in his own file and made it a field of detector

    @cmaglie
    cmaglie committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    7ff78b3 View commit details
    Browse the repository at this point in the history

  6. Fixed comment

    @cmaglie
    cmaglie committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    68a9748 View commit details
    Browse the repository at this point in the history

  7. Renamed variable (typo)

    @cmaglie
    cmaglie committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    db0db78 View commit details
    Browse the repository at this point in the history

  8. Simplified handling of de-duplication of cache hit messages 

    This equivalent change moves the 'first' variable closer to his definition and use.
    @cmaglie
    cmaglie committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    e937db8 View commit details
    Browse the repository at this point in the history

  9. Implemented a better include-cache

    @cmaglie
    cmaglie committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    e4f9927 View commit details
    Browse the repository at this point in the history

  10. Remove the old, no longer used, includeCache

    @cmaglie
    cmaglie committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    80ab805 View commit details
    Browse the repository at this point in the history

  11. Simplified error reporting in library detection 

    There is no need to duplicate the preprocessResult/Err variables.
This also simplifies naming making it more straighforward.
    @cmaglie
    cmaglie committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    94b4b3d View commit details
    Browse the repository at this point in the history

  12. Remove useless targetFilePath variable

    @cmaglie
    cmaglie committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    fc7779f View commit details
    Browse the repository at this point in the history

  13. Slight improvement of removeBuildFromSketchFiles

    @cmaglie
    cmaglie committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    d072f10 View commit details
    Browse the repository at this point in the history

  14. Rename variables for clarity

    @cmaglie
    cmaglie committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    55021c8 View commit details
    Browse the repository at this point in the history

  15. Removed hardcoded build.warn_data_percentage in build.options file 

    Also fixed the "low memory" warning printer.
    @cmaglie
    cmaglie committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    39f2000 View commit details
    Browse the repository at this point in the history

  16. Renamed variables for clarity

    @cmaglie
    cmaglie committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    9c19adf View commit details
    Browse the repository at this point in the history

  17. Renamed variables for clarity

    @cmaglie
    cmaglie committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    4f06901 View commit details
    Browse the repository at this point in the history

  18. Pre-compute sourceFile fields, and save the in the includes.cache

    @cmaglie
    cmaglie committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    a808c17 View commit details
    Browse the repository at this point in the history

  19. Added ObjFileIsUpToDate method to sourceFile

    @cmaglie
    cmaglie committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    f1f8327 View commit details
    Browse the repository at this point in the history

  20. Implemented parallel task runner

    @cmaglie
    cmaglie committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    86bdc5f View commit details
    Browse the repository at this point in the history

  21. Simplify use of properties.SplitQuotedString 

    The new release of the library allow ignoring the returned error.

arduino/go-properties-orderedmap#42
    @cmaglie
    cmaglie committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    bfe6d8c View commit details
    Browse the repository at this point in the history

  22. Use runner.Task in GCC preprocessor 

    It slightly simplifies code, but also provide the basis for the next
commits.
    @cmaglie
    cmaglie committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    f81fdbc View commit details
    Browse the repository at this point in the history

  23. Parallelize library discovery phase in compile

    @cmaglie
    cmaglie committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    8f3155f View commit details
    Browse the repository at this point in the history

  24. The number of jobs in library detection now follows --jobs flag

    @cmaglie
    cmaglie committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    8833b28 View commit details
    Browse the repository at this point in the history

  25. Reordered properties construction for clarity

    @cmaglie
    cmaglie committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    bc97f3d View commit details
    Browse the repository at this point in the history

  26. Reordered compileFileWithRecipe for clarity

    @cmaglie
    cmaglie committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    60e6c8f View commit details
    Browse the repository at this point in the history

  27. Added integration test

    @cmaglie
    cmaglie committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    8237ac6 View commit details
    Browse the repository at this point in the history

  28. fix: libraries are recompiled if the list of include paths changes

    @cmaglie
    cmaglie committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    87765a4 View commit details
    Browse the repository at this point in the history