Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use datafusion re-exported dependencies #856

Merged
merged 2 commits into from
Sep 7, 2024

Conversation

emgeee
Copy link
Contributor

@emgeee emgeee commented Sep 5, 2024

Which issue does this PR close?

Closes #855.

Rationale for this change

What changes are included in this PR?

Changes datafusion-python to use re-exported dependencies from datafusion. The only dependency that must be included as it is not currently re-exported is datafusion_substrait.

Are there any user-facing changes?

No

@emgeee emgeee changed the title Use datafusion re-exported crates Use datafusion re-exported dependencies Sep 5, 2024
Copy link
Contributor

@timsaucer timsaucer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks very good. Thank you! Just one suggestion.

src/lib.rs Outdated Show resolved Hide resolved
@emgeee emgeee changed the title Use datafusion re-exported dependencies (chore): Use datafusion re-exported dependencies Sep 6, 2024
@emgeee emgeee changed the title (chore): Use datafusion re-exported dependencies chore: Use datafusion re-exported dependencies Sep 6, 2024
@timsaucer timsaucer merged commit 6154ef9 into apache:main Sep 7, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(minor) Remove dependencies on datafusion subcrates and use core re-exports instead
2 participants