-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix toc generation for api docs #9655
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9655 +/- ##
============================================
+ Coverage 15.77% 15.81% +0.03%
- Complexity 12542 12554 +12
============================================
Files 5623 5629 +6
Lines 491611 492023 +412
Branches 60012 61243 +1231
============================================
+ Hits 77568 77813 +245
- Misses 405584 405887 +303
+ Partials 8459 8323 -136
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
@DaanHoogland @rajujith check/confirm the API & its updated category
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the indentation issue is not a problem for pythonc : clgtm
@blueorangutan package |
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11052 |
Co-authored-by: dahn <daan.hoogland@gmail.com>
@blueorangutan package |
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11090 |
Manually QA on the built apidocs html/site is needed. |
@JoaoJandre I think, it's better to have this in 4.20, as the APIs would have the updated/correct categories in the docs. |
Agree @sureshanaparti could be useful as usually the major release api docs is what we upload to project website. Let me help QA this. |
Manually built and tested - OK. API docs LGTM. Screenshot below, passing to @JoaoJandre to consider and merge: |
Description
This PR modifies the categories of the commands API Documentation.
Details
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?