feat: support gcp secret manager #11436
Conversation
dosubot
bot
added
the
size:XXL
|
Hi @kayx23 Please take a look at the documentation when you are free to see if there are any problems. 🫡 |
t/secret/gcp.t
Outdated
|
|
||
| __DATA__ | ||
|
|
||
| === TEST 1: sanity |
There was a problem hiding this comment.
change sanity to a meaningful title, and it should contain schema and validate
There was a problem hiding this comment.
All Resolved.
I have fixed these issues, please review them again.
| aud = self.token_uri, | ||
| scope = self.scope, | ||
| iat = get_timestamp(), | ||
| exp = get_timestamp() + (60 * 60) |
There was a problem hiding this comment.
60 * 60, it is a magic number, pls add a comment
There was a problem hiding this comment.
I don't think we know exactly what it means because the code is a simple copy of the apisix/plugins/google-cloud-logging/oauth.lua file.
There was a problem hiding this comment.
we need to create an issue to make apisix/plugins/google-cloud-logging/oauth.lua use this new file?
There was a problem hiding this comment.
Yes, when this PR is merged, I will create a new PR to use this new file.
|
@HuanXin-Chen There were some failures in CI involving traffic-split3.t, no worries, just merge the master branch into your dev branch |
|
@bzp2010 @membphis @soulbird @kayx23 @shreemaan-abhishek |
Description
Many enterprises are utilizing cloud services from AWS and GCP, relying on the secret manager provided by these platforms to handle sensitive information. Integrating Apache APISIX with these secret managers can streamline the process of using sensitive information within APISIX, enabling users to manage and utilize cloud-stored sensitive data more conveniently, thus enhancing the overall security and usability of the system.
This PR has completed the support for GCP. It added the gcp.lua file to the original secret module, allowing users to store their secret information on GCP using the same reference method as before.
Checklist