Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More thorough support for newlines across the grammar #258

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ForNeVeR
Copy link
Collaborator

@ForNeVeR ForNeVeR commented Mar 25, 2024

For context, see #236.

Should fix #182.

Closes #236 (as superseded).

TODO:

  • Make the existing tests green
  • More tests for the initial case

@ForNeVeR ForNeVeR self-assigned this Mar 25, 2024
@ForNeVeR ForNeVeR changed the title Parser/newlines More thorough support for newlines across the grammar Mar 25, 2024
@ForNeVeR ForNeVeR force-pushed the parser/newlines branch 2 times, most recently from 4abc8be to 5aa7e8b Compare May 22, 2024 22:09
En3Tho and others added 2 commits May 25, 2024 00:32
For #182, we want to distinguish a single newline versus several newlines in a PowerShell file.

This change allows that.
@ForNeVeR
Copy link
Collaborator Author

ForNeVeR commented May 24, 2024

Folding / expand selection difference (folding.ps1).
Main:
image

PR:
image

Trailing spaces are no longer considered a part of the block. This is incorrect and we'll need to fix it somehow before merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing error of newline + pipe operator combination
2 participants