v1.4.1 (#18)

* v1.4.1 * v1.4.1 * v1.4.1
andreww1011 · Jun 16, 2022 · b5e646e · b5e646e
1 parent 9a4c7ae
commit b5e646e
Show file tree

Hide file tree

Showing 9 changed files with 30 additions and 9 deletions.
diff --git a/dist/FilterMultiSelect.js b/dist/FilterMultiSelect.js
diff --git a/dist/FilterMultiSelect.js.map b/dist/FilterMultiSelect.js.map
diff --git a/dist/filter-multi-select-bundle.js b/dist/filter-multi-select-bundle.js
diff --git a/dist/filter-multi-select-bundle.js.map b/dist/filter-multi-select-bundle.js.map
diff --git a/dist/filter-multi-select-bundle.min.js b/dist/filter-multi-select-bundle.min.js
diff --git a/dist/filter-multi-select-bundle.min.js.map b/dist/filter-multi-select-bundle.min.js.map
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "filter-multi-select",
-  "version": "1.4.0",
+  "version": "1.4.1",
   "description": "Multiple select dropdown with filter jQuery plugin.",
   "scripts": {
     "clean": "rimraf dist && rimraf coverage",

diff --git a/src/FilterMultiSelect.ts b/src/FilterMultiSelect.ts
@@ -454,7 +454,7 @@ export default class FilterMultiSelect {
                                     0; //magic number 
         const numOptions: number = this.options.length;
         const restrictSelection: boolean = this.maxNumSelectedItems > 0 && this.maxNumSelectedItems < numOptions;
-        this.maxNumSelectedItems = restrictSelection ? this.maxNumSelectedItems : numOptions + 1;
+        this.maxNumSelectedItems = restrictSelection ? this.maxNumSelectedItems : numOptions + 1;  //magic number
         this.selectAllOption = restrictSelection ? 
                 new FilterMultiSelect.RestrictedSelectAllOption(this, name, args.selectAllText) : 
                 new FilterMultiSelect.UnrestrictedSelectAllOption(this, name, args.selectAllText);
@@ -532,6 +532,12 @@ export default class FilterMultiSelect {
         this.selectionCounter.className = 'mr-2';
 
         this.div.className = 'filter-multi-select dropdown';
+        if (this.maxNumSelectedItems > 1) {
+            let v: string = this.maxNumSelectedItems >= this.options.length ? "" : this.maxNumSelectedItems.toString();
+            this.div.setAttribute('multiple',v);
+        } else {
+            this.div.setAttribute('single',"");
+        }
 
         if (this.isDisabled()) {
             this.disableNoPermissionCheck();