Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix hidden input opactiy #63

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

antuneslv
Copy link
Contributor

When the OTP input is focused, the base input, which should be hidden, is faintly visible. If you zoom in, you can notice it. I'm not sure if it was intentional to set the opacity to 0.01, but I fixed it by setting the opacity to 0 so that the input doesn't appear at all.

opacity

@anday013

@anday013
Copy link
Owner

anday013 commented Jul 8, 2024

Hi, @antuneslv . Thank you for yet another contribution. However, as I remember correctly, with 0 opacity one of the platforms (Android I guess) was failing to display the context menu. Can u please try to "paste" some code through context menu on both platforms, to be sure that nothing is breaking?

@antuneslv
Copy link
Contributor Author

Hi @anday013 , unfortunately I don't have an iOS device to test... 😞 However, I did test it on Android, and the context menu works perfectly:

android

@anday013
Copy link
Owner

@antuneslv I mean this menu :) When you hold, or double click on the input
image

@antuneslv
Copy link
Contributor Author

This menu also works on Android. :)

android2

@antuneslv
Copy link
Contributor Author

Hi @anday013, I'm not sure if you're still waiting for an iOS test, but as I mentioned, unfortunately, I don't have a way to test on that platform. If you need to close the PR because of this, I completely understand.

@anday013
Copy link
Owner

Hi @antuneslv , I have a chance to test on iOS, I'll handle that. The only thing is that I am on vacation right now, so I apologize for the delays :)

@anday013
Copy link
Owner

anday013 commented Aug 1, 2024

Tested works fine! Thanks!

@anday013 anday013 merged commit 612fbec into anday013:main Aug 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants