If target image is a block device, access it directly #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omnivagant
force-pushed
the
block-device-target
branch
from
63eae00
to
e064a61
Compare
|
This is a nice idea, but it’s incomplete – |
omnivagant
force-pushed
the
block-device-target
branch
from
e064a61
to
0366082
Compare
|
Like so? In some sense I feel like I'm a bit lazy here in keeping the |
|
Yes, there are more things that should be renamed and documented to make sense after this change. |
omnivagant
force-pushed
the
block-device-target
branch
from
0366082
to
891fb1e
Compare
|
What if we just call it |
|
Yes, that’s fine, but the help message needs to be updated as well. |
omnivagant
force-pushed
the
block-device-target
branch
from
891fb1e
to
c51537c
Compare
|
Of course, like so? |
jirutka
force-pushed
the
block-device-target
branch
from
c51537c
to
9303dab
Compare
Access the block device directly. This will allow a user to specify a block device, like an LVM volume or ZFS zvol, as target. Co-Authored-By: Jakub Jirutka <jakub@jirutka.cz>
jirutka
force-pushed
the
block-device-target
branch
from
9303dab
to
352609f
Compare
|
Yes, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow a user to specify a block device, like an LVM volume or
ZFS zvol, as target.