sls flusher support metricstore #1731
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
shaoxuan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
henryzhx8
requested changes
Sep 2, 2024
core/sdk/Client.cpp
Outdated
| @@ -219,15 +220,20 @@ namespace sdk { | |||
| sls_logs::SlsCompressType compressType, | |||
| const std::string& compressedLogGroup, | |||
| uint32_t rawSize, | |||
| const std::string& hashKey) { | |||
| const std::string& hashKey, | |||
| bool isMetrics) { | |||
There was a problem hiding this comment.
这里最好改成enum，可以复用flushersls里的，因为以后可能还有trace
There was a problem hiding this comment.
这个是存储类型，trace 没有特点存储，都是 logstore
| map<string, string> httpHeader; | ||
| httpHeader[CONTENT_TYPE] = TYPE_LOG_PROTOBUF; | ||
| if (!mKeyProvider.empty()) { | ||
| httpHeader[X_LOG_KEYPROVIDER] = mKeyProvider; | ||
| } | ||
| httpHeader[X_LOG_BODYRAWSIZE] = std::to_string(rawSize); | ||
| httpHeader[X_LOG_COMPRESSTYPE] = Client::GetCompressTypeString(compressType); | ||
| return SynPostLogStoreLogs(project, logstore, compressedLogGroup, httpHeader, hashKey); | ||
| if (isMetrics) { | ||
| return SynPostMetricStoreLogs(project, logstore, compressedLogGroup, httpHeader); |
There was a problem hiding this comment.
metricstore 这个渠道自动 hash
core/sdk/Client.cpp
Outdated
Comment on lines
335
to
336
| const std::string& hashKey, | ||
| int64_t hashKeySeqID, |
Comment on lines
+187
to
+189
| if (url.find(METRICSTORES) != std::string::npos) { | ||
| throw LOGException(LOGE_REQUEST_ERROR, httpMessage.content); | ||
| } |
There was a problem hiding this comment.
搜一下IsLogServiceResponse()，应该在flushersls里面还有一个地方有类似的
core/flusher/sls/FlusherSLS.h
Outdated
| @@ -80,7 +80,7 @@ class FlusherSLS : public HttpFlusher { | |||
| std::string mRegion; | |||
| std::string mEndpoint; | |||
| std::string mAliuid; | |||
| TelemetryType mTelemetryType = TelemetryType::LOG; | |||
| sls_logs::SlsTelemetryType mTelemetryType = sls_logs::SlsTelemetryType::SLS_TELEMETRY_TYPE_LOGS; | |||
There was a problem hiding this comment.
落文件时候，之前这个不记录，recover 时候只能按 log recover
added 2 commits
September 20, 2024 09:43
Conflicts: core/plugin/flusher/sls/FlusherSLS.h core/sdk/Client.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logtail 2.0 add sls Metrics support
Old version #908