Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduction of support to TTML #15

Draft
wants to merge 381 commits into
base: develop
Choose a base branch
from
Draft

Introduction of support to TTML #15

wants to merge 381 commits into from

Conversation

alexandercerutti
Copy link
Owner

@alexandercerutti alexandercerutti commented Feb 18, 2024 •
edited
Loading

Breaking changes

  • (Re)Introduced Entities.Style;
  • Removed Entities.Tag.setStyles;
  • Removed the concepts of offset and length in lines;
  • (Behavior) Adapters now are in charge of specifing the entities to apply to specific cues, in a ordered way (captions-renderer won't re-order them anymore)

@alexandercerutti
Changed how a block is ignored by using trackingTree
cc3d2b2
@alexandercerutti
Removed unused BlockTypes and tuples
142225e
@alexandercerutti
Added more tests for ContentBlockReader
dfef858
@alexandercerutti
Merge branch 'feature/ttml/nodetree-refactor' into feature/ttml-adapter
0834529
@alexandercerutti
Fixed issue with fractional parts of seconds while parsing time with …
e0cf88a 
…different bases
@alexandercerutti
Added support to strings in tracks
431e098
@alexandercerutti
Added new TrackingTree Node ascendCurrentNode instead of popping and,…
e878ea4 
… by mistake, actually popping
@alexandercerutti
Commented old Adapter logic and replaced it with base new structure
060765e
@alexandercerutti
Added support to styles saving on new adapter implementation
b83010e
@alexandercerutti
Added region parsing through new system
37ead69
@alexandercerutti
Renamed BlockType.GROUP into CONTENT_ELEMENT
0177831
@alexandercerutti
Refactored Relationship verification to have more precise and standar…
16ad2d0 
…d relationship verification
@alexandercerutti
Removed TrackingTree and IgnoredSymbol to switch to an attribute system;
666976e 
Added attribute for pre-emission of a token. This avoid for a div/body token to be emitted different times.

Removed also shells creation when emitting nodes
@alexandercerutti
Added another test about inline-region
8ed336d
@alexandercerutti
Set Tokenizer to trim trailing and leading whitespaces when emitting …
05f122c 
…strings
@alexandercerutti
Added test for region inside paragraph
0c079d9
@alexandercerutti
Added pre-emission check on END_TAG
4c07bc2
@alexandercerutti
Removed old relationship contraints functions from Adapter
c3c20a8
@alexandercerutti
Renamed TRACKED attribute to GROUP_TRACKED
6a068b5
@alexandercerutti
Added isBlockClassElement guard function
67418f7
@alexandercerutti
Changed internal structure of RelatioshipTree in order to start with …
1263ea4 
…a null-ish root and to have better comparison between elements in the tree
@alexandercerutti
Fixed error message
f5c9656
@alexandercerutti
Set NodeTree root to start from an empty root
0270061
@alexandercerutti
Added ignored node check on string tokens
4fa777e
@alexandercerutti
Moved tt root check to happen before node pushing and relationshipTre…
c581aaa 
…e initialization
@alexandercerutti
Removed parent check of relationshiptree of the token
c45bbcb
@alexandercerutti
Added check on last block and on ignoring until a documentBlockTuple …
f3ae72a 
…is not found
@alexandercerutti
Renamed BlockType REGION and similar to LAYOUT
b36df6d
@alexandercerutti
Removed useless check
18674b4
@alexandercerutti
Set adapter to throw an error if discovery is completed without a roo…
df6c8fb 
…t node
@alexandercerutti
Added check to ignore parent element if we find an inline region elem…
1ed9573 
…ent while we have already another region active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexandercerutti alexandercerutti

Labels
💥 Breaking Change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi line does not preserve style
1 participant
@alexandercerutti