Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multithreaded OnDiskReader #355

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

vagrawal
Copy link

@vagrawal vagrawal commented Jan 28, 2021

Reading from disk is by far the slowest part of the training for us as the parsing is single threaded and blocking. This change reduced our entire end to end training time by 4 times and it is even slightly faster than reading from memory as that involves one run of single threaded reading from disk.

This stores upto 10 next parsed blocks in memory and could have hardware_concurrency number of blocks in processing. So the upper bound of memory is fixed and is independent of size of data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant