Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Archival #538

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

Archival #538

wants to merge 12 commits into from

Commits on Sep 5, 2023

  1. Add rudimentary archival test

    @lukasjuhrich
    lukasjuhrich committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    ddd0c83 View commit details
    Browse the repository at this point in the history

  2. Extract timedelta from archivable membership filter

    @lukasjuhrich
    lukasjuhrich committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    8da8f9f View commit details
    Browse the repository at this point in the history

  3. reintroduce cast to silence warning

    @lukasjuhrich
    lukasjuhrich committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    c0848ac View commit details
    Browse the repository at this point in the history

  4. Add test for longer delta in archivable query

    @lukasjuhrich
    lukasjuhrich committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    74c074f View commit details
    Browse the repository at this point in the history

  5. Add archive_users stub and test

    @lukasjuhrich
    lukasjuhrich committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    0144646 View commit details
    Browse the repository at this point in the history

  6. Extract last membership select from archive query 

    Introduces `select_users_and_last_mem` returning the `select`
    @lukasjuhrich
    lukasjuhrich committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    2e99189 View commit details
    Browse the repository at this point in the history

  7. Switch membership selection to from … select style 

    This suits the relational algebra pipeline better, as the entities we
select from actually correspond to a projection done after all the
joins and filtering.

This change does not alter the compilation result of this select statement.
    @lukasjuhrich
    lukasjuhrich committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    c0f1036 View commit details
    Browse the repository at this point in the history

  8. Decouple archivable users select statement from execution

    @lukasjuhrich
    lukasjuhrich committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    e509d76 View commit details
    Browse the repository at this point in the history

  9. Switch archival query to from … select style

    @lukasjuhrich
    lukasjuhrich committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    cee036d View commit details
    Browse the repository at this point in the history

  10. Add comment explaining window args

    @lukasjuhrich
    lukasjuhrich committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    e39606b View commit details
    Browse the repository at this point in the history

  11. Switch archivable member selection from delta to year-based cutoff 

    Fixes an oversight in the previous implementation of #470

Also, expand on the test suite substantially while retaining a decent
runtime.

Refs #67
    @lukasjuhrich
    lukasjuhrich committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    9c9a2e8 View commit details
    Browse the repository at this point in the history

  12. Improve archivability test performance 

    1. We restrict the ranges to a smaller subset which is still
   meaningful.
2. We use the `select` statement itself rather than the wrapper method
   adding a ton of `joinedload`s.
    @lukasjuhrich
    lukasjuhrich committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    f715e29 View commit details
    Browse the repository at this point in the history