Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Lazy loading breaks noop #96

Merged
merged 2 commits into from
Sep 9, 2024
Merged

fix: Lazy loading breaks noop #96

merged 2 commits into from
Sep 9, 2024

Conversation

adammcdonagh
Copy link
Owner

Prevent new lazy loading logic to load in unresolved variables from conflicting with the no op functionality where some variables are intentionally not resolved.

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.77%. Comparing base (f1b00c8) to head (e6ec538).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/opentaskpy/config/loader.py 86.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
- Coverage   88.85%   88.77%   -0.08%     
==========================================
  Files          20       20              
  Lines        2396     2397       +1     
==========================================
- Hits         2129     2128       -1     
- Misses        267      269       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adammcdonagh adammcdonagh merged commit f2a4a3a into main Sep 9, 2024
25 checks passed
@adammcdonagh adammcdonagh deleted the fix/lazy-loading branch September 9, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant