More stuff for the ImGui text HUD tab #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Any type of alphabetical sorting should be fine, I guess I'd be most concerned how to make it as easy as possible to find stuff from the user perspective. |
lipsanen
reviewed
Sep 17, 2024
UncraftedName
force-pushed
the
imgui-text-hud
branch
from
ee7c55b
to
9b7bfd0
Compare
|
tyvm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added all of the
spt_hudcvars to the HUD tab in ImGui except for ent_info. It looks like this now:Internally, the ImGui tab sorts cvars by their wrangled (legacy) name and
spt_hudsorts by a custom sort key. Is it okay if I change thespt_hudlogic to sort by name instead of using a sort key so that way they match up? We haven't been grouping the HUD cvars in any meaningful way so I think it should be fine to change the order.