Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates from Shiny review #404

Merged
merged 31 commits into from
Feb 22, 2024
Merged

Updates from Shiny review #404

merged 31 commits into from
Feb 22, 2024

Conversation

cristinamullin
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2024

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (cb2183f) 44.67% compared to head (5af5daa) 46.35%.

❗ Current head 5af5daa differs from pull request most recent head cdb5b10. Consider uploading reports for the commit cdb5b10 to get more accurate results

Files Patch % Lines
R/Filtering.R 0.00% 28 Missing ⚠️
R/RequiredCols.R 40.00% 6 Missing ⚠️
R/ResultFlagsDependent.R 0.00% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #404      +/-   ##
===========================================
+ Coverage    44.67%   46.35%   +1.67%     
===========================================
  Files           14       14              
  Lines         3201     3193       -8     
===========================================
+ Hits          1430     1480      +50     
+ Misses        1771     1713      -58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hillarymarler and others added 7 commits February 22, 2024 12:03
simplified function, updated documentation and examples
corrected df name bug, documentation updates (address use of "assessment", changed to "analysis"
added TADA_OrderCols()
add TADA to examples for functions that are not exported
@cristinamullin cristinamullin merged commit 400b12e into develop Feb 22, 2024
6 checks passed
@cristinamullin cristinamullin deleted the shiny_review branch February 22, 2024 22:20
@cristinamullin cristinamullin restored the shiny_review branch February 26, 2024 19:30
@cristinamullin cristinamullin deleted the shiny_review branch February 26, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants