Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Index entities #863

Merged
merged 22 commits into from
Sep 20, 2024
Merged

feat: Index entities #863

merged 22 commits into from
Sep 20, 2024

Conversation

attiks
Copy link
Contributor

@attiks attiks commented Jul 29, 2024

Refs: #RW-1035

@attiks attiks marked this pull request as draft July 29, 2024 14:54
Copy link

github-actions bot commented Jul 29, 2024

Build output

Composer Validate success

PHP Lint success

Docker Build success

Environment Setup success

Site Install success

PHP Code Sniffer success

Software Versions Docker version 26.1.3, build b72abbb PHP 8.3.11 (cli) (built: Aug 31 2024 04:39:21) (NTS) Copyright (c) The PHP Group Zend Engine v4.3.11, Copyright (c) Zend Technologies with Zend OPcache v8.3.11, Copyright (c), by Zend Technologies with Xdebug v3.3.2, Copyright (c) 2002-2024, by Derick Rethans Composer version 2.7.9 2024-09-04 14:43:28
Drupal Logs
PHP Logs

Pusher: @attiks, Action: pull_request, Workflow: Run tests

@attiks attiks mentioned this pull request Sep 10, 2024
@attiks attiks marked this pull request as ready for review September 10, 2024 15:04
@attiks attiks requested review from orakili and cafuego and removed request for orakili September 10, 2024 15:04
cafuego
cafuego previously approved these changes Sep 12, 2024
Copy link
Contributor

@cafuego cafuego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need some extra settings in Ansible, eh? I am approving the PR, but:

  • The lambda(s) should go into their own repository, which will also let us auto-deploy them.
  • The README and code still think there are multiple datasource, knowlege bases and indices. Do we need another push? :-)

@attiks
Copy link
Contributor Author

attiks commented Sep 13, 2024

For opinions @cafuego @orakili

@orakili can you also check which fields we need/don't need

cafuego
cafuego previously approved these changes Sep 18, 2024
Copy link
Contributor

@cafuego cafuego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕹️ for the cleanup. I have no opinions on the fields.

Copy link

Coverage Report

Totals Coverage
Statements: 9.05% ( 1104 / 12193 )
Methods: 11.92% ( 82 / 688 )
Lines: 8.88% ( 1022 / 11505 )

@attiks attiks merged commit 0059071 into develop Sep 20, 2024
3 checks passed
@attiks attiks deleted the feature/RW-1035 branch September 20, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants