Merge pull request #173 from UCBoulder/bug/correct-bug-where-the-line…

…search-norm-wasnt-incrementing MAINT: Corrected bug where the line-search target norm didn't increme…
UCBoulder · Sep 18, 2024 · b8b09e6 · b8b09e6
2 parents 3eef8d6 + f4fbb83
commit b8b09e6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/docs/sphinx/changelog.rst b/docs/sphinx/changelog.rst
@@ -47,6 +47,7 @@ Bug Fixes
 - Corrected issue where the wrong Jacobian was being used in checkDescentDirection (:pull:`156`). By `Nathan Miller`_.
 - Corrected bug when forming an Eigen::Map (pull:`164`). By `Nathan Miller`_.
 - Corrected bug where the cohesions can go negative (pull:`165`). By `Nathan Miller`_.
+- Corrected bug where the line search target residual didn't reset (pull:`173`). By `Nathan Miller`_.
 
 Bug Fixes
 =========

diff --git a/src/cpp/tardigrade_hydra.h b/src/cpp/tardigrade_hydra.h
@@ -1848,7 +1848,7 @@ namespace tardigradeHydra{
 
             void setTolerance( const floatVector &tolerance );
 
-            void incrementIteration( ){ _iteration++; }
+            void incrementIteration( ){ _iteration++; resetLSIteration( ); }
 
             void incrementLSIteration( ){ _LSIteration++; }